pysal / pointpats

Planar Point Pattern Analysis in PySAL
https://pysal.org/pointpats/
BSD 3-Clause "New" or "Revised" License
80 stars 26 forks source link

update min supported Python and testing workflow #140

Closed jGaboardi closed 3 weeks ago

jGaboardi commented 1 month ago

This PR:

jGaboardi commented 1 month ago

Two One environment failing:

Any thoughts or ideas here?

martinfleis commented 1 month ago

I am not sure what that explore test was supposed to test but it may be related to recent changes in folium.

The GDAL issue is a broken feedstock, we can ignore that here.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 69.7%. Comparing base (e152ac8) to head (573bf0b). Report is 2 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/pysal/pointpats/pull/140/graphs/tree.svg?width=650&height=150&src=pr&token=0S5nzc1oBN&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pysal)](https://app.codecov.io/gh/pysal/pointpats/pull/140?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pysal) ```diff @@ Coverage Diff @@ ## main #140 +/- ## ======================================= + Coverage 69.6% 69.7% +0.1% ======================================= Files 12 12 Lines 1774 1775 +1 ======================================= + Hits 1235 1237 +2 + Misses 539 538 -1 ``` [see 1 file with indirect coverage changes](https://app.codecov.io/gh/pysal/pointpats/pull/140/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pysal)
knaaptime commented 3 weeks ago

@jGaboardi there's a PR in your fork that will get things moving. I'm not sure what is different about the folium on 3.12 but the size of the dict containing the map contents is different.

jGaboardi commented 3 weeks ago

@jGaboardi there's a PR in your fork that will get things moving. I'm not sure what is different about the folium on 3.12 but the size of the dict containing the map contents is different.

done