Closed ljwolf closed 3 years ago
I've just realized this is class-specific logic residing in the superclass. This should definitely not be handled in the superclass Envelopes
. Instead, if Jenv
needs special behavior, we need to override Envelopes.mapper
with Jenv.mapper
.
Also, I think, the j function does two calculation passes (one at l587 and one immediately afterwards in the correction)?
Using the book tokyo data for user
95795770@N00
, I can get envelopes for G and F, but not J. I think this means whatever shape fix used here is wrong.fwiw there are 419 coordinates, and I can compute the
Jenv
of a random pattern with 419 points.