Closed ljwolf closed 4 years ago
Yes, not sure why the tests are not running... I also (now testing on OSX) get failures in the numba code. I need to double check. @sjsrey have you ran this locally?
I believe this is now resolved and is ready to merge. Very basic errors in the remaining functions.
Also, I note we do not have CI on the minimum bounding circle or rectangles?
I'm exploring this locally and will add test if we don't have them
Yes, not sure why the tests are not running... I also (now testing on OSX) get failures in the numba code. I need to double check. @sjsrey have you ran this locally?
I think the tests were not triggered due to conflicts in the source. Just resolved those so let's see.
Yes, not sure why the tests are not running... I also (now testing on OSX) get failures in the numba code. I need to double check. @sjsrey have you ran this locally?
I think the tests were not triggered due to conflicts in the source. Just resolved those so let's see.
The conflict was holding up the tests. Updated a PR into your branch if you need it.
This adds a numba implementation of the minimum bounding circle code. This won't have too much of a speedup on most cases, unless the input points are very convex & the convex hull is large.