Open nathanjmcdougall opened 3 years ago
That’ll do it! We’ll make this change soon and get a point release out. Thanks!
Get Outlook for iOShttps://aka.ms/o0ukef
From: nathanjmcdougall notifications@github.com Sent: Thursday, February 25, 2021 9:11:23 PM To: pysal/pointpats pointpats@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Subject: [pysal/pointpats] HAS_NUMBA left undefined (#70)
This message could be from someone attempting to impersonate a member of UoB. Please do not share information with the sender without verifying their identity. If in doubt, please contact the IT Service Desk for advice. --
In centrography.py, there's a check for in the numba module is available:
try: from numba import njit, boolean
HAS_NUMBA = True
Etc. But if numba isn't installed, then HAS_NUMBA is undefined, which can cause problems when using functions, e.g. minimum_bounding_circle.
I'm not sure, but potentially the fix is as simple as adding HAS_NUMBA = False in the Exception to the above try statement:
except ModuleNotFoundError:
def njit(func, **kwargs):
return func
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/pysal/pointpats/issues/70, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AARFR465OKCRHKPUW2EPZRTTA24HXANCNFSM4YHHRPIQ.
In centrography.py, there's a check for if the
numba
module is available:Etc. But if
numba
isn't installed, thenHAS_NUMBA
is undefined, which can cause problems when using functions, e.g.minimum_bounding_circle
.I'm not sure, but potentially the fix is as simple as adding
HAS_NUMBA = False
in the Exception to the abovetry
statement: