search

pysal / pointpats

Planar Point Pattern Analysis in PySAL
https://pysal.org/pointpats/
BSD 3-Clause "New" or "Revised" License
83 stars 26 forks source link

GHA: fix target #88

Closed martinfleis closed 1 year ago

martinfleis commented 1 year ago

@jGaboardi wrong branch...

jGaboardi commented 1 year ago

We should make a note to swap this target branch back to main once we can change the default branch.

martinfleis commented 1 year ago

I even think that the Github feature does that for you.

jGaboardi commented 1 year ago

xref #64

martinfleis commented 1 year ago

It seems that this is now working as expected. I see the same two failures locally. One seem to be dealt with in #69 and the other one seems to be some tiny difference, so change in tolerance should do the trick.

martinfleis commented 1 year ago

I suggest merging this once the remaining envs finish and update #69 from master. We should also see if this fixed RTD.

martinfleis commented 1 year ago

Also, we can then merge bits of https://github.com/pysal/pointpats/pull/64 that are still relevant.

jGaboardi commented 1 year ago

I suggest merging this once the remaining envs finish and update #69 from master. We should also see if this fixed RTD.

Works for me.

martinfleis commented 1 year ago

RTD works now - https://pointpats.readthedocs.io/en/latest/api.html

jGaboardi commented 1 year ago

Awesome work on this @martinfleis!