search

pysal / region

A library for Spatially-Explicit Regionalization
BSD 3-Clause "New" or "Revised" License
14 stars 16 forks source link

missing files: skater/south_inf_q20.ary #19

Closed sjsrey closed 5 years ago

sjsrey commented 5 years ago

When installing via

pip install https://github.com/pysal/region/archive/master.zip

into a prebuilt and activated conda environment for osnap I hit

FileNotFoundError: [Errno 2] No such file or directory: '/home/serge/anaconda3/envs/osnap-region/lib/python3.6/site-packages/region/skater/south_inf_q20.ary'

looks like the file doesn't come along for the installation ride?

ljwolf commented 5 years ago

sorry, probably needs to be added to MANIFEST.in.

ljwolf commented 5 years ago

that should only be required for testing, though... not sure why you're hitting it in installation?

sjsrey commented 5 years ago

I think because: https://github.com/pysal/region/blob/master/region/skater/__init__.py#L2

knaaptime commented 5 years ago

fwiw, i also get a AttributeError: 'Series' object has no attribute 'reshape' when trying to use skater, but i can raise that elsewhere

ljwolf commented 5 years ago

Yes, @knaaptime replication code would help me address that. On this, I can submit a PR removing the read statement in test_skater. that's not supposed to be there.

ljwolf commented 5 years ago

fwiw, i also get a AttributeError: 'Series' object has no attribute 'reshape' when trying to use skater, but i can raise that elsewhere

Thinking about this error, I bet it's because I'm not using asarray on the input, and something in scipy/sklearn is mad that the input is a Pandas series, not an array.

I can PR to fix that if that's indeed what's happening.