search

pysal / region

A library for Spatially-Explicit Regionalization
BSD 3-Clause "New" or "Revised" License
14 stars 16 forks source link

update requirements #3

Closed sjsrey closed 6 years ago

sjsrey commented 6 years ago

I think these are it for dependencies (the listed ones would pull in scipy and numpy on install).

yogabonito commented 6 years ago

Thanks for your effort, @sjsrey! In my docs-branch I have a setup.py file with even more dependencies. Are sklearn and pytest also requirements of the packages you listed? If yes, I will merge your PR immediately, otherwise it would be good to include them in the list.

BTW I plan to include the setup.py and requirements.txt from my docs-branch soon. After my graduation in October I would like to add Travis-CI and documentation to region.

ljwolf commented 6 years ago

@yogabonito has this been resolved? having merged #5, can we close?

yogabonito commented 6 years ago

Having read PySAL's and other projects' docs I think it suffices to have the requirements in setup.py. What do you think, @sjsrey @ljwolf? Meanwhile I have also added the license to the docs. The corresponding PR will come soon.

ljwolf commented 6 years ago

ping?

yogabonito commented 6 years ago

The PR I mentioned is now here. Sorry for the long delay. A bounty of 50 points on stackoverflow last week helped me finally add Travis CI support :)

ljwolf commented 6 years ago

Oh! I didn't know you were waiting/had asked on that! I wonder whether it could be solved using conda forge?

https://anaconda.org/conda-forge/pulp

On Wed, Apr 4, 2018 at 3:20 PM yogabonito notifications@github.com wrote:

The PR https://github.com/pysal/region/pull/6 I mentioned is now here. Sorry for the long delay. A bounty of 50 points on stackoverflow https://stackoverflow.com/questions/49564890/pulp-not-working-with-travis-ci/49619737#49619737 last week helped me finally add Travis CI support :)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pysal/region/pull/3#issuecomment-378616845, or mute the thread https://github.com/notifications/unsubscribe-auth/ACJY8wCpSDVRAkruaspV0G-F6XxK2Pv_ks5tlNbCgaJpZM4PhrkA .

-- Levi John Wolf Lecturer in Quantitative Human Geography | University of Bristol Fellow | Center for Spatial Data Science, University of Chicago Associate Member | Center for Multilevel Modeling, University of Bristol Interim Director | Q-Step Program, University of Bristol ljwolf.org

yogabonito commented 6 years ago

No problem, I didn't tell you (I didn't want to bother you with these details) ;) I didn't think of conda but I will give it a try once I face similar problems again. For now, I think we can leave .travis.yml as it is as I'm sitting in the train headed towards holidays :)