search

pysal / region

A library for Spatially-Explicit Regionalization
BSD 3-Clause "New" or "Revised" License
14 stars 16 forks source link

[WIP] integrate regionskate #4

Closed ljwolf closed 6 years ago

ljwolf commented 6 years ago

this is a work in progress tracking PR to integrate the skater module.

Don't close. I'll ping when ready.

Thanks!

ljw

ljwolf commented 6 years ago

OK, this rolls a bunch of stuff plus the skater integration in regionskate together now.

@yogabonito I will enable travis rn, but otherwise I'll merge this myself

ljwolf commented 6 years ago

seems like tests will fail until this is resolved?

ljwolf commented 6 years ago

This is only on hold for the reason identified above in python 3.6 for some reason.

In python 3.5, #7 occurs. Not sure what to do here except bone up on pytest.

ljwolf commented 6 years ago

Nearly there.

pytest stlil considers the warning raised in Spanning_Tree(n_clusters=np.inf) an error, so I'm trying modifying the pytest.ini.

Second, there still are tons of substantive failures in non-spanning tree code in 3.6...

ljwolf commented 6 years ago

Errors are now in the substantive code for the networkx and scipy.sparse fit methods only for 3.6. Maybe there was an nx ordering change? I'm at a loss on this atm.

ljwolf commented 6 years ago

I fixed the networkx-related errors back in libpysal and now this passes.

ljwolf commented 6 years ago

I fixed the networkx-related errors back in libpysal and now this passes.