search

pysal / segregation

Segregation Measurement, Inferential Statistics, and Decomposition Analysis
https://pysal.org/segregation/
BSD 3-Clause "New" or "Revised" License
111 stars 26 forks source link

[WIP] NA handling #130

Closed renanxcortes closed 5 years ago

renanxcortes commented 5 years ago

This handles https://github.com/pysal/segregation/issues/105 in a conservative way: it raises an informative error whenever the user has missing data in the input columns, but adds a fillna useful option if he/she wants to input 0 in these missings values to calculate the indexes.

All tests passed.

renanxcortes commented 5 years ago

After what @sjsrey said yesterday about PySAL handling NA's I was thinking also changing this PR to make a check if there is NAs and only raise an informative ValueError and that is it. The user would have to decide what to do with the NAs, any thoughts on that?

renanxcortes commented 5 years ago

I'd prefer to merge https://github.com/pysal/segregation/pull/131 rather than this one. So, if https://github.com/pysal/segregation/pull/131 gets merged, I'll close this one.

renanxcortes commented 5 years ago

Closed due to https://github.com/pysal/segregation/pull/131.