Closed renanxcortes closed 5 years ago
should we go ahead and close #130?
should we go ahead and close #130?
I'm +1 for that.
should we go ahead and close #130?
I'm +1 for that.
But before, I'd like to check if this one is okay merging for you.
as i keep thinking about this, I think a warning is most appropriate. It's not really an error of any kind, so there's no need to fail just because NAs are present, but we should let the user know
as i keep thinking about this, I think a warning is most appropriate. It's not really an error of any kind, so there's no need to fail just because NAs are present, but we should let the user know
Sure, just changed this in https://github.com/pysal/segregation/pull/131/commits/cb5182a604e0bf0f358c3d2ecd493ef7dda5661b.
This implements https://github.com/pysal/segregation/pull/130#issuecomment-522137184. So, this is PR is open in favor of https://github.com/pysal/segregation/pull/130.