search

pysal / segregation

Segregation Measurement, Inferential Statistics, and Decomposition Analysis
https://pysal.org/segregation/
BSD 3-Clause "New" or "Revised" License
111 stars 26 forks source link

Raise an informative error when input data have NAs (also update geosnap links) #131

Closed renanxcortes closed 5 years ago

renanxcortes commented 5 years ago

This implements https://github.com/pysal/segregation/pull/130#issuecomment-522137184. So, this is PR is open in favor of https://github.com/pysal/segregation/pull/130.

knaaptime commented 5 years ago

should we go ahead and close #130?

renanxcortes commented 5 years ago

should we go ahead and close #130?

I'm +1 for that.

renanxcortes commented 5 years ago

should we go ahead and close #130?

I'm +1 for that.

But before, I'd like to check if this one is okay merging for you.

knaaptime commented 5 years ago

as i keep thinking about this, I think a warning is most appropriate. It's not really an error of any kind, so there's no need to fail just because NAs are present, but we should let the user know

renanxcortes commented 5 years ago

as i keep thinking about this, I think a warning is most appropriate. It's not really an error of any kind, so there's no need to fail just because NAs are present, but we should let the user know

Sure, just changed this in https://github.com/pysal/segregation/pull/131/commits/cb5182a604e0bf0f358c3d2ecd493ef7dda5661b.