search

pysal / segregation

Segregation Measurement, Inferential Statistics, and Decomposition Analysis
https://pysal.org/segregation/
BSD 3-Clause "New" or "Revised" License
111 stars 26 forks source link

col names hardcoded in _generate_counterfactual #148

Closed knaaptime closed 3 years ago

knaaptime commented 4 years ago

here and below the columns are hardcoded with strings but they should be variables

renanxcortes commented 4 years ago

here and below the columns are hardcoded with strings but they should be variables

Yep, good catch! Further, I think when we drop these columns in https://github.com/pysal/segregation/blob/3c59c8e221cb97ea3d8acf7d72af4b28f2944f04/segregation/util/util.py#L206, this should be variables.

knaaptime commented 3 years ago

resolved by #147