pysal / segregation

Segregation Measurement, Inferential Statistics, and Decomposition Analysis

https://pysal.org/segregation/

BSD 3-Clause "New" or "Revised" License

111 stars 26 forks source link

GHA and setup.py maintenance #160

Closed jGaboardi closed 3 years ago

jGaboardi commented 3 years ago

This PR updates:

setup.py:
- correct website
- supported Python versions
build_docs.yml
- streamlined syntax
- add caching
unittests.yml
- add nightly cron job
- streamlined syntax
upload_package.yml
- bump actions/checkout and actions/setup-python versions

jGaboardi commented 3 years ago

@renanxcortes @knaaptime There is currently no Development Status classifier for segregation, which there are with other PySAL submodules (libpysal for example). This should be added to setup.py.

list of classifiers

codecov-io commented 3 years ago

Codecov Report

Merging #160 (8943798) into master (04422ad) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #160   +/-   ##
=======================================
  Coverage   85.75%   85.75%           
=======================================
  Files          65       65           
  Lines        2779     2779           
=======================================
  Hits         2383     2383           
  Misses        396      396

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 04422ad...8943798. Read the comment docs.

knaaptime commented 3 years ago

sweet, thanks for this. two questions:

are you sure cranking down the timeout from 90 to 20 leaves enough margin? is there a downside to the timeout being too long?
looks like there's no mamba specification in here, right?

jGaboardi commented 3 years ago

are you sure cranking down the timeout from 90 to 20 leaves enough margin? is there a downside to the timeout being too long?

This is only for the docs build action on Ubuntu/Py3.9, which should only take 3 minutes for the setup phase (currently for segregation) and around the 30 seconds for the docs build phase (currently for spaghetti). We can keep current the timeout if you prefer, but I think 20 minutes is long enough to account for connectivity issues.

looks like there's no mamba specification in here, right?

Correct, no mamba here. As you mentioned before, it's not really doing anything for us yet, but shall I add it in for completeness?