search

pysal / segregation

Segregation Measurement, Inferential Statistics, and Decomposition Analysis
https://pysal.org/segregation/
BSD 3-Clause "New" or "Revised" License
111 stars 26 forks source link

Versioneer #187

Closed sjsrey closed 2 years ago

sjsrey commented 2 years ago

We have a circular import that arises in the move to versioneer.

Issue crops up at segregation/aspatial/aspatial_indexes.py when testing version for deprecation decorators (Line 21)

sjsrey commented 2 years ago

As far as the versioneer stuff, this looks good. I'm wondering how to solve that circular import problem though.

https://github.com/sjsrey/segregation/commit/fa6a08ca41982bcd07081800a46ca83b1f649064

codecov-commenter commented 2 years ago

Codecov Report

Merging #187 (fa6a08c) into master (3459227) will decrease coverage by 2.44%. The diff coverage is 41.34%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #187      +/-   ##
==========================================
- Coverage   64.27%   61.83%   -2.45%     
==========================================
  Files         118      119       +1     
  Lines        4445     4784     +339     
==========================================
+ Hits         2857     2958     +101     
- Misses       1588     1826     +238
Impacted Files Coverage Δ
segregation/_version.py 40.65% <40.65%> (ø)
segregation/__init__.py 100.00% <100.00%> (ø)
segregation/aspatial/aspatial_indexes.py 17.21% <100.00%> (+0.18%) :arrow_up:
segregation/inference/randomization.py 21.62% <0.00%> (-19.82%) :arrow_down:
segregation/inference/comparative.py 61.64% <0.00%> (-10.96%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3459227...fa6a08c. Read the comment docs.

knaaptime commented 2 years ago

we could just go ahead and remove the deprecated modules. Instead of allowing the functions to work with a deprecation warning, we could remove everything except for a warning explaining that if you need the old API, you need to downgrade segregation<2

sjsrey commented 2 years ago

we could just go ahead and remove the deprecated modules. Instead of allowing the functions to work with a deprecation warning, we could remove everything except for a warning explaining that if you need the old API, you need to downgrade segregation<2

+1 as we said we would be removing the deprecation warnings in 2.2.0.