search

pysal / spaghetti

SPAtial GrapHs: nETworks, Topology, & Inference
http://pysal.org/spaghetti/
BSD 3-Clause "New" or "Revised" License
271 stars 70 forks source link

try versioneer action #697

Closed jGaboardi closed 1 year ago

jGaboardi commented 1 year ago

This PR is a first attempt at implementing a versioneer update action (xref https://github.com/geopandas/geopandas/pull/2638, etc.) due to release action failure (in turn caused by #690).

jGaboardi commented 1 year ago

Welp... seems like versioneer requires a setup.cfg file...

jGaboardi commented 1 year ago

I had thought this ability had been added in versioneer (xref https://github.com/python-versioneer/python-versioneer/pull/330). But seems like I misunderstood.

jGaboardi commented 1 year ago

May have missed a step.

martinfleis commented 1 year ago

A side note - with the packages built from scratch, I've recently used setuptools_scm instead of versioneer. From a user perspective it works the same as it pulls tags from git but it has very little hassle around. Just this and this. The rest is magic. You don't need any other files like with versioneer and works with pyproject.toml.

jGaboardi commented 1 year ago

@martinfleis So we'll probably want to stick with versioneer across the ecosystem (at least for now), right? If so, would you say the path of least resistance is adding back a minimal setup.cfg with only versioneer info it? (Though not ideal...).

martinfleis commented 1 year ago

Yeah, I am just not happy that we're stuck with having all setup.py because of versioneer and GitHub, setup.cfg and pyproject.toml... it contradicts all the efforts to have it all in one place.

jGaboardi commented 1 year ago

Yeah, I am just not happy that we're stuck with having all setup.py because of versioneer and GitHub, setup.cfg and pyproject.toml... it contradicts all the efforts to have it all in one place.

Exactly...

jGaboardi commented 1 year ago

xref https://github.com/python-versioneer/python-versioneer/issues/146, https://github.com/python-versioneer/python-versioneer/issues/338

martinfleis commented 1 year ago

Ah, good. At least something :)

martinfleis commented 1 year ago

You will also need to include https://github.com/geopandas/geopandas/pull/2695

jGaboardi commented 1 year ago

I'll go ahead and update pypa/gh-action-pypi-publish@master to pypa/gh-action-pypi-publish@release/v1 here.

xref https://github.com/pysal/spopt/issues/337