pysal / spaghetti

SPAtial GrapHs: nETworks, Topology, & Inference

http://pysal.org/spaghetti/

BSD 3-Clause "New" or "Revised" License

260 stars 69 forks source link

Open jGaboardi opened 1 year ago

jGaboardi commented 1 year ago

720 introduced a small `ruff` regression where the `geom_col` keyword is no longer used in `util._arcs_as_gdf()`, which triggers a `ruff` failure in pre-commit.

The thought here is that maybe we should remove the geom_col argument in element_as_gdf()? And always default to "geometry".

EDIT

martinfleis commented 1 year ago

Can you think of a use case when you want the column to be called differently and it couldn't be done via an intermediate rename_geometry call?

jGaboardi commented 1 year ago

Nope, I can't think of anything. Let's nix it.