pysal / spaghetti

SPAtial GrapHs: nETworks, Topology, & Inference
http://pysal.org/spaghetti/
BSD 3-Clause "New" or "Revised" License
260 stars 69 forks source link

Bug fixes #755

Closed ggarzonie closed 6 months ago

ggarzonie commented 6 months ago

Changed code in section 2.8 of notebook. Section 5 of the connected components notebook didn't work, changes in util.py fixed it. I have tested the code using test_network.py. I'm not sure how to assign a reviewer.

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (b14c9e7) 99.3% compared to head (a2f8b95) 99.3%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/pysal/spaghetti/pull/755/graphs/tree.svg?width=650&height=150&src=pr&token=CdbQLUL9pT&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pysal)](https://app.codecov.io/gh/pysal/spaghetti/pull/755?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pysal) ```diff @@ Coverage Diff @@ ## main #755 +/- ## ===================================== Coverage 99.3% 99.3% ===================================== Files 4 4 Lines 1140 1141 +1 ===================================== + Hits 1132 1133 +1 Misses 8 8 ``` | [Files](https://app.codecov.io/gh/pysal/spaghetti/pull/755?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pysal) | Coverage Δ | | |---|---|---| | [spaghetti/util.py](https://app.codecov.io/gh/pysal/spaghetti/pull/755?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pysal#diff-c3BhZ2hldHRpL3V0aWwucHk=) | `100.0% <100.0%> (ø)` | |
jGaboardi commented 6 months ago

@ggarzonie Thanks for the PR!