search

pysal / spaghetti

SPAtial GrapHs: nETworks, Topology, & Inference
http://pysal.org/spaghetti/
BSD 3-Clause "New" or "Revised" License
260 stars 69 forks source link

310-no-optional CI failures [2024-03-16] #763

Closed jGaboardi closed 3 months ago

jGaboardi commented 3 months ago

Current failures in 310-no-optional seem to come through esda from libpysal. 

ImportError while importing test module '/home/runner/work/spaghetti/spaghetti/spaghetti/__init__.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
../../../micromamba/envs/test/lib/python3.10/importlib/__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
spaghetti/__init__.py:8: in <module>
    from .network import (
spaghetti/network.py:11: in <module>
    import esda
../../../micromamba/envs/test/lib/python3.10/site-packages/esda/__init__.py:10: in <module>
    from . import adbscan, shape  # noqa F401
../../../micromamba/envs/test/lib/python3.10/site-packages/esda/adbscan.py:12: in <module>
    from libpysal.cg.alpha_shapes import alpha_shape_auto
../../../micromamba/envs/test/lib/python3.10/site-packages/libpysal/__init__.py:23: in <module>
    from . import cg
../../../micromamba/envs/test/lib/python3.10/site-packages/libpysal/cg/__init__.py:7: in <module>
    from .kdtree import *
../../../micromamba/envs/test/lib/python3.10/site-packages/libpysal/cg/kdtree.py:9: in <module>
    from scipy import inf
E   ImportError: cannot import name 'inf' from 'scipy' (/home/runner/micromamba/envs/test/lib/python3.10/site-packages/scipy/__init__.py)
ImportError while importing test module '/home/runner/work/spaghetti/spaghetti/spaghetti/__init__.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
../../../micromamba/envs/test/lib/python3.10/importlib/__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
spaghetti/__init__.py:8: in <module>
    from .network import (
spaghetti/network.py:11: in <module>
    import esda
../../../micromamba/envs/test/lib/python3.10/site-packages/esda/__init__.py:10: in <module>
    from . import adbscan, shape  # noqa F401
../../../micromamba/envs/test/lib/python3.10/site-packages/esda/adbscan.py:12: in <module>
    from libpysal.cg.alpha_shapes import alpha_shape_auto
../../../micromamba/envs/test/lib/python3.10/site-packages/libpysal/__init__.py:23: in <module>
    from . import cg
../../../micromamba/envs/test/lib/python3.10/site-packages/libpysal/cg/__init__.py:7: in <module>
    from .kdtree import *
../../../micromamba/envs/test/lib/python3.10/site-packages/libpysal/cg/kdtree.py:9: in <module>
    from scipy import inf
E   ImportError: cannot import name 'inf' from 'scipy' (/home/runner/micromamba/envs/test/lib/python3.10/site-packages/scipy/__init__.py)

It seems that the "no optional" is causing the issue in version deps. Since (1) geopandas and shapely have been hard reqs since libpysal==4.8.0. It's probably time to drop the "optional" regrading them.