gpd & shp as hard reqs -- no optional testing -- #763

[jGaboardi]

This PR resolves #763

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.3%. Comparing base (3fc7fe8) to head (b3fd763).

Additional details and impacted files

[](https://app.codecov.io/gh/pysal/spaghetti/pull/764?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pysal) ```diff @@ Coverage Diff @@ ## main #764 +/- ## ===================================== Coverage 99.3% 99.3% ===================================== Files 4 4 Lines 1141 1141 ===================================== Hits 1133 1133 Misses 8 8 ``` | [Files](https://app.codecov.io/gh/pysal/spaghetti/pull/764?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pysal) | Coverage Δ | | |---|---|---| | [spaghetti/network.py](https://app.codecov.io/gh/pysal/spaghetti/pull/764?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pysal#diff-c3BhZ2hldHRpL25ldHdvcmsucHk=) | `99.1% <100.0%> (ø)` | |

[jGaboardi]

Failure due to #762, irrelevant to this PR.

[martinfleis]

I am not sure I agree here. Neither geopandas nor shapely are at the moment required by spaghetti. They are required by dependencies but that does not qualify them as requirements here. Or do I miss something?

[jGaboardi]

I am not sure I agree here. Neither geopandas nor shapely are at the moment required by spaghetti. They are required by dependencies but that does not qualify them as requirements here. Or do I miss something?

While geopandas and shapely are not needed for all functionality with spaghetti, they are required for some functionality (+ I need to update here and here) and used directly. For quality of life (and for when/if I ever get the time to refactor spaghetti), I'd like to make the full requirements.