search

pysal / spaghetti

SPAtial GrapHs: nETworks, Topology, & Inference
http://pysal.org/spaghetti/
BSD 3-Clause "New" or "Revised" License
260 stars 69 forks source link

update docstring tests -- `numpy-2.0` failures #769

Closed jGaboardi closed 1 week ago

jGaboardi commented 1 week ago

This PR

martinfleis commented 1 week ago

Can we maybe try to fix it rather than disabling failing tests?

jGaboardi commented 1 week ago

@martinfleis

Yes, this was done in haste yesterday evening. I'm on the fence as to:

  1. update the types in docstrings (X.Y vs. np.float64(X.Y)); or
  2. make actual changes in the code base

Very worth noting that none of the actual functional tests fail, only the docstring examples.

martinfleis commented 1 week ago

make actual changes in the code base

Not worth it imho, just creates unnecessary copies of data.

jGaboardi commented 1 week ago
codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.3%. Comparing base (17a411c) to head (6d03fbb).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/pysal/spaghetti/pull/769/graphs/tree.svg?width=650&height=150&src=pr&token=CdbQLUL9pT&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pysal)](https://app.codecov.io/gh/pysal/spaghetti/pull/769?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pysal) ```diff @@ Coverage Diff @@ ## main #769 +/- ## ===================================== Coverage 99.3% 99.3% ===================================== Files 4 4 Lines 1133 1133 ===================================== Hits 1125 1125 Misses 8 8 ``` | [Files](https://app.codecov.io/gh/pysal/spaghetti/pull/769?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pysal) | Coverage Δ | | |---|---|---| | [spaghetti/analysis.py](https://app.codecov.io/gh/pysal/spaghetti/pull/769?src=pr&el=tree&filepath=spaghetti%2Fanalysis.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pysal#diff-c3BhZ2hldHRpL2FuYWx5c2lzLnB5) | `100.0% <100.0%> (ø)` | | | [spaghetti/network.py](https://app.codecov.io/gh/pysal/spaghetti/pull/769?src=pr&el=tree&filepath=spaghetti%2Fnetwork.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pysal#diff-c3BhZ2hldHRpL25ldHdvcmsucHk=) | `99.1% <ø> (ø)` | | | [spaghetti/util.py](https://app.codecov.io/gh/pysal/spaghetti/pull/769?src=pr&el=tree&filepath=spaghetti%2Futil.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pysal#diff-c3BhZ2hldHRpL3V0aWwucHk=) | `100.0% <ø> (ø)` | |