search

pysal / spglm

SParse Generalized Linear Models (spglm)
https://pysal.org/spglm/
BSD 3-Clause "New" or "Revised" License
33 stars 20 forks source link

Remove np.float due to deprecation error #32

Closed Ziqi-Li closed 1 year ago

Ziqi-Li commented 1 year ago

At this line, Numpy 1.24 will raise an error for np.float, which is deprecated. This causes error in downstream mgwr's auto testing.

Numpy 1.24 release note

martinfleis commented 1 year ago

This is affecting current fresh environments. Can we cut a patch release that includes this?

jGaboardi commented 1 year ago

This is affecting current fresh environments. Can we cut a patch release that includes this?

It has been a very long time since I have done a release without our modern GHA tooling. If we can wait until the completion of #43, then I can take of it.

martinfleis commented 1 year ago

Agree to get #43 in first.

We will also need @TaylorOshan to share PyPI rights or add a token later. But there's currently only a single person with PyPI access, it would be wise to share it anyway with someone else (@jGaboardi?).

jGaboardi commented 1 year ago

Agree to get #43 in first.

We will also need @TaylorOshan to share PyPI rights or add a token later. But there's currently only a single person with PyPI access, it would be wise to share it anyway with someone else (@jGaboardi?).

Yes, we will need PyPI rights... Can @ljwolf or @sjsrey help with this?

martinfleis commented 1 year ago

No, only @TaylorOshan has PyPI rights here.