search

pysal / spopt

Spatial Optimization
https://pysal.org/spopt/
BSD 3-Clause "New" or "Revised" License
305 stars 46 forks source link

Review messaging in KN-PMP #426

Closed jGaboardi closed 10 months ago

jGaboardi commented 10 months ago

This MR:

xref #414

codecov[bot] commented 10 months ago

Codecov Report

Merging #426 (9219fa9) into main (a330389) will not change coverage. The diff coverage is 100.0%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/pysal/spopt/pull/426/graphs/tree.svg?width=650&height=150&src=pr&token=6DbcV5GVAc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pysal)](https://app.codecov.io/gh/pysal/spopt/pull/426?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pysal) ```diff @@ Coverage Diff @@ ## main #426 +/- ## ===================================== Coverage 77.8% 77.8% ===================================== Files 27 27 Lines 2638 2638 ===================================== Hits 2053 2053 Misses 585 585 ``` | [Files](https://app.codecov.io/gh/pysal/spopt/pull/426?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pysal) | Coverage Δ | | |---|---|---| | [spopt/locate/p\_median.py](https://app.codecov.io/gh/pysal/spopt/pull/426?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pysal#diff-c3BvcHQvbG9jYXRlL3BfbWVkaWFuLnB5) | `98.6% <100.0%> (ø)` | |
jGaboardi commented 10 months ago

I need to update the test for this. Will push up a fix shortly.