search

pysal / spreg

Spatial econometric regression in Python
https://pysal.org/spreg/
Other
66 stars 23 forks source link

modernize infrastructure #121

Closed knaaptime closed 11 months ago

codecov[bot] commented 11 months ago

Codecov Report

Merging #121 (0fe03b2) into main (4ff0b0d) will not change coverage. The diff coverage is 100.0%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #121   +/-   ##
=====================================
  Coverage   69.1%   69.1%           
=====================================
  Files         40      40           
  Lines       8723    8723           
  Branches    1195    1253   +58     
=====================================
  Hits        6027    6027           
  Misses      2316    2316           
  Partials     380     380
Files Changed Coverage Δ
spreg/diagnostics_panel.py 96.0% <100.0%> (ø)
knaaptime commented 11 months ago

@pedrovma this should be ready. Doesnt touch any substantive code, but brings infrastructure in line with the rest of the ecosystem

pedrovma commented 11 months ago

This is great! Thank you so much.

knaaptime commented 11 months ago

thanks for the close review james! All of the recipes are basically just copied over from tobler, so there may be cases like v3 vs v4 that can be directly updated.

jGaboardi commented 11 months ago

thanks for the close review james! All of the recipes are basically just copied over from tobler, so there may be cases like v3 vs v4 that can be directly updated.

LOL I can read this as "dang it, James".

Those versions are probably not going to cause much problem for now.

At some point in the future *waves hands ambiguously*, we should actually hammer out all the inconsistencies across the ecosystem. Alas, there are only so many hours in the day.

knaaptime commented 11 months ago

LOL I can read this as "dang it, James".

not even close. this is exactly why i tag you for review! :)