search

pysal / spreg

Spatial econometric regression in Python
https://pysal.org/spreg/
Other
72 stars 24 forks source link

Deprecating check_spat_diag #147

Closed pedrovma closed 2 months ago

pedrovma commented 2 months ago

Check is done in check_weights.

This is to fix issue #146.

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 67.6%. Comparing base (c9565aa) to head (9c42c02). Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
spreg/ols_regimes.py 33.3% 1 Missing and 1 partial :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/pysal/spreg/pull/147/graphs/tree.svg?width=650&height=150&src=pr&token=9VrJpIYIl3&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pysal)](https://app.codecov.io/gh/pysal/spreg/pull/147?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pysal) ```diff @@ Coverage Diff @@ ## main #147 +/- ## ======================================= - Coverage 67.6% 67.6% -0.0% ======================================= Files 41 41 Lines 9626 9622 -4 Branches 1433 1433 ======================================= - Hits 6508 6504 -4 Misses 2704 2704 Partials 414 414 ``` | [Files with missing lines](https://app.codecov.io/gh/pysal/spreg/pull/147?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pysal) | Coverage Δ | | |---|---|---| | [spreg/ols.py](https://app.codecov.io/gh/pysal/spreg/pull/147?src=pr&el=tree&filepath=spreg%2Fols.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pysal#diff-c3ByZWcvb2xzLnB5) | `76.0% <100.0%> (+0.3%)` | :arrow_up: | | [spreg/twosls.py](https://app.codecov.io/gh/pysal/spreg/pull/147?src=pr&el=tree&filepath=spreg%2Ftwosls.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pysal#diff-c3ByZWcvdHdvc2xzLnB5) | `82.5% <100.0%> (-0.1%)` | :arrow_down: | | [spreg/twosls\_regimes.py](https://app.codecov.io/gh/pysal/spreg/pull/147?src=pr&el=tree&filepath=spreg%2Ftwosls_regimes.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pysal#diff-c3ByZWcvdHdvc2xzX3JlZ2ltZXMucHk=) | `64.3% <100.0%> (-0.2%)` | :arrow_down: | | [spreg/twosls\_sp\_regimes.py](https://app.codecov.io/gh/pysal/spreg/pull/147?src=pr&el=tree&filepath=spreg%2Ftwosls_sp_regimes.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pysal#diff-c3ByZWcvdHdvc2xzX3NwX3JlZ2ltZXMucHk=) | `63.2% <ø> (-0.1%)` | :arrow_down: | | [spreg/user\_output.py](https://app.codecov.io/gh/pysal/spreg/pull/147?src=pr&el=tree&filepath=spreg%2Fuser_output.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pysal#diff-c3ByZWcvdXNlcl9vdXRwdXQucHk=) | `58.0% <100.0%> (+0.3%)` | :arrow_up: | | [spreg/ols\_regimes.py](https://app.codecov.io/gh/pysal/spreg/pull/147?src=pr&el=tree&filepath=spreg%2Fols_regimes.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pysal#diff-c3ByZWcvb2xzX3JlZ2ltZXMucHk=) | `31.8% <33.3%> (-0.7%)` | :arrow_down: |