search

pysal / spreg

Spatial econometric regression in Python
https://pysal.org/spreg/
Other
66 stars 23 forks source link

Infrastructure maintenance #99

Closed jGaboardi closed 2 years ago

jGaboardi commented 2 years ago

Addressing #58, #96, #98

codecov[bot] commented 2 years ago

Codecov Report

Merging #99 (baed4d7) into master (a879748) will increase coverage by 0.0%. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #99   +/-   ##
======================================
  Coverage    77.7%   77.7%           
======================================
  Files          39      39           
  Lines        7825    7859   +34     
  Branches     1092    1094    +2     
======================================
+ Hits         6082    6110   +28     
- Misses       1439    1445    +6     
  Partials      304     304
Impacted Files Coverage Δ
spreg/ols_regimes.py 40.8% <0.0%> (-0.6%) :arrow_down:
spreg/error_sp_regimes.py 74.3% <0.0%> (-0.3%) :arrow_down:
spreg/twosls_sp_regimes.py 71.1% <0.0%> (-0.1%) :arrow_down:
spreg/summary_output.py 85.6% <0.0%> (-<0.1%) :arrow_down:
spreg/regimes.py 80.9% <0.0%> (+0.1%) :arrow_up:
spreg/error_sp_het_regimes.py 88.5% <0.0%> (+0.1%) :arrow_up:
spreg/error_sp_hom_regimes.py 88.1% <0.0%> (+0.1%) :arrow_up:
spreg/diagnostics.py 85.8% <0.0%> (+0.1%) :arrow_up:
spreg/ml_lag_regimes.py 87.7% <0.0%> (+0.2%) :arrow_up:
spreg/ml_error_regimes.py 87.5% <0.0%> (+0.2%) :arrow_up:
... and 1 more
jGaboardi commented 2 years ago

This PR is ready for review. Following successful merge I can cut a fresh release. This should probably be a minor release (v1.3.0), but I will defer to your judgment @pedrovma if you want it to be a patch release (v1.2.5).

pedrovma commented 2 years ago

This PR is ready for review. Following successful merge I can cut a fresh release. This should probably be a minor release (v1.3.0), but I will defer to your judgment @pedrovma if you want it to be a patch release (v1.2.5).

Given all the infrastructure changes you've made, I believe v1.3.0 makes more sense. Thank you so much!