Closed jGaboardi closed 11 months ago
Note that unlike versioneer, setuptools_scm only loads the version during the installation, so when having an editable install (pip install -e .
), the version it shows is static and doesn't show the actual commit situation from the last tag once you change something.
Although this is a relative drawback from using versioneer
, my interpretation is that the pros of using setuptools_scm
far outweigh the cons. Things just seem to "work". What are your thoughts, @martinfleis ?
Yeah, I agree. This is mostly a dev-focused little thing but I prefer a clean repo over up-to-date commit hash in the version.
+1
xref https://github.com/pysal/submodule_template/pull/39#issuecomment-1419446231
We should probably add in
pyproject.toml
, and with that we can streamline:setup.py
,setup.cfg
pyproject.toml
and remove individual reqs filesMoreover, if we want to adopt
setuptools_scm
for version controlruff
for linting we can:setup.py
,setup.cfg
,versioneer.py
,_version.py
,.pylintrc
,.coveragerc
cc @knaaptime, @weikang9009, @martinfleis