pysal / submodule_template

This provides a template for submodules to use in the PySAL project
BSD 3-Clause "New" or "Revised" License
2 stars 10 forks source link

add `pyproject.toml`, etc. #40

Closed jGaboardi closed 11 months ago

jGaboardi commented 1 year ago

xref https://github.com/pysal/submodule_template/pull/39#issuecomment-1419446231

We should probably add in pyproject.toml, and with that we can streamline:

Moreover, if we want to adopt setuptools_scm for version control ruff for linting we can:

cc @knaaptime, @weikang9009, @martinfleis

martinfleis commented 1 year ago

Note that unlike versioneer, setuptools_scm only loads the version during the installation, so when having an editable install (pip install -e .), the version it shows is static and doesn't show the actual commit situation from the last tag once you change something.

jGaboardi commented 1 year ago

Although this is a relative drawback from using versioneer, my interpretation is that the pros of using setuptools_scm far outweigh the cons. Things just seem to "work". What are your thoughts, @martinfleis ?

martinfleis commented 1 year ago

Yeah, I agree. This is mostly a dev-focused little thing but I prefer a clean repo over up-to-date commit hash in the version.

knaaptime commented 1 year ago

+1