pysal / tobler

Spatial interpolation, Dasymetric Mapping, & Change of Support
https://pysal.org/tobler
BSD 3-Clause "New" or "Revised" License
144 stars 30 forks source link

integrate smaup into tobler #139

Closed AnGWar26 closed 1 year ago

AnGWar26 commented 3 years ago

Addresses #51 and partially #84

This implementation does not automatically run smaup. It requires that the user pass their own weights object to calculate Moran's I, and choose the number of regions that they will be running smaup against. It also does not prioritize user interaction with the statistic (I suppose you could import the wrapper function itself and run it), it only tells the user whether the variable being used is affected by the MAUP. image

Let me know what you think

codecov-io commented 3 years ago

Codecov Report

Merging #139 (44c42e3) into master (32c8525) will decrease coverage by 0.72%. The diff coverage is 67.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #139      +/-   ##
==========================================
- Coverage   81.25%   80.52%   -0.73%     
==========================================
  Files          17       20       +3     
  Lines         832      873      +41     
==========================================
+ Hits          676      703      +27     
- Misses        156      170      +14     
Impacted Files Coverage Δ
tobler/model/glm.py 82.60% <33.33%> (-7.40%) :arrow_down:
tobler/dasymetric/masked_area_interpolate.py 68.42% <37.50%> (-22.49%) :arrow_down:
tobler/area_weighted/area_interpolate.py 80.00% <44.44%> (-1.43%) :arrow_down:
tobler/__init__.py 100.00% <100.00%> (ø)
tobler/diagnostics/__init__.py 100.00% <100.00%> (ø)
tobler/diagnostics/smaup.py 100.00% <100.00%> (ø)
tobler/tests/test_diagnostics.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 32c8525...44c42e3. Read the comment docs.