codecov[bot]
commented
2 years ago Codecov Report
Merging #157 (5f932c7) into master (91184d9) will decrease coverage by
7.56%. The diff coverage is51.96%.
@@ Coverage Diff @@
## master #157 +/- ##
==========================================
- Coverage 82.04% 74.47% -7.57%
==========================================
Files 20 20
Lines 958 1003 +45
==========================================
- Hits 786 747 -39
- Misses 172 256 +84 | Impacted Files | Coverage Δ | |
|---|---|---|
| tobler/dasymetric/__init__.py | 100.00% <ø> (ø) |
|
| tobler/_version.py | 40.65% <40.65%> (ø) |
|
| tobler/tests/test_model.py | 83.87% <83.87%> (ø) |
|
| tobler/dasymetric/masked_area_interpolate.py | 87.50% <85.71%> (-3.41%) |
:arrow_down: |
| tobler/dasymetric/raster_tools.py | 94.44% <93.33%> (+62.73%) |
:arrow_up: |
| tobler/__init__.py | 100.00% <100.00%> (ø) |
|
| tobler/area_weighted/__init__.py | 100.00% <100.00%> (ø) |
|
| tobler/area_weighted/area_interpolate.py | 86.30% <100.00%> (+4.87%) |
:arrow_up: |
| tobler/model/__init__.py | 100.00% <100.00%> (ø) |
|
| tobler/model/glm.py | 92.00% <100.00%> (+2.00%) |
:arrow_up: |
| ... and 6 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 6fa573a...5f932c7. Read the comment docs.
resolves the bug uncovered in #165 using a different approach to carry out dasymetric masking (thanks @johnziebro!).
Also:
utiland elsewhereglm_pixel_adjusted, which was experimental to begin with and is causing testing headaches. If we want to return to this, there's probably a better (and faster) way using our new tooling