pysal / tobler

Spatial interpolation, Dasymetric Mapping, & Change of Support
https://pysal.org/tobler
BSD 3-Clause "New" or "Revised" License
144 stars 30 forks source link

Site docs return 404 #204

Open JosiahParry opened 4 months ago

JosiahParry commented 4 months ago

The 3 vignettes at pysal.org/tobler presently return a 404 with nbviewer.

For example: https://nbviewer.org/github/pysal/tobler/blob/master/notebooks/census_to_hexgrid.ipynb

knaaptime commented 4 months ago

hm, looks like thats cause they're still pointing at master instead of main (swap and it works fine)

im not actually sure where thats happening cause that notebook is sitting in the docs dir where it should be. Will take a look, thanks for raising

knaaptime commented 4 months ago

@jGaboardi do you remember where those are set?

jGaboardi commented 4 months ago

https://nbviewer.org/github/pysal/tobler/blob/master/notebooks/census_to_hexgrid.ipynb

Where is that above link coming from? Are you simply launching nbviewer manually or do we have that link embedded somewhere in the repo/docs site?

jbousquin commented 4 months ago

Looks like those nbviewer links are hardcoded directly in the index.rst (lines ~13, 21, 29, so just a link update?).

For the docs tutorial page, tutorial.rst is pointing to the notebooks in docs/notebooks (e.g., 01_interpolation_methods_overview.ipynb). I ran into this recently in a different project where I didn't want to maintain two copies. sphinx may not like ../ and I found nbsphinx_link worked for me if you're open to the added docs requirement.

jGaboardi commented 4 months ago

Looks like those nbviewer links are hardcoded directly in the index.rst (lines ~13, 21, 29, so just a link update?).

Yep, this looks to be the case!

knaaptime commented 4 months ago

Sweet, thanks @jbousquin! Nbsphinx_link looks great