search

pysal / tobler

Spatial interpolation, Dasymetric Mapping, & Change of Support
https://pysal.org/tobler
BSD 3-Clause "New" or "Revised" License
146 stars 30 forks source link

crs checking #50

Closed knaaptime closed 4 years ago

knaaptime commented 4 years ago

we do some CRS checking to make sure that the rasters align properly with input vector data. Right now, those checks are pretty naive and issue a warning if there's a mismatch, but with the new pyproj now upstream in geopandas, we can be much more intelligent about these checks

jGaboardi commented 4 years ago

May we want to put that in some kind of utility embedded in libpysal so can use it across submodules? Could be useful in spaghetti.

knaaptime commented 4 years ago

I havent added anything fancy, but we were doing a length check before, since the crs used to be a dictionary. The new crs is a class so that check causes breakage with new versions of geopandas. I've gone ahead and removed it, but we should do a hotfix release here, otherwise you cant use tobler's raster functions

knaaptime commented 4 years ago

this is now handled in geopandas