search

pysal / tobler

Spatial interpolation, Dasymetric Mapping, & Change of Support
https://pysal.org/tobler
BSD 3-Clause "New" or "Revised" License
146 stars 30 forks source link

Add Pycnophylactic Interpolation #95

Closed sjsrey closed 3 years ago

sjsrey commented 4 years ago

Tobler paper

danlewis85 commented 3 years ago

In case it is helpful, here is some python code I wrote to do pycnophylactic smoothing: https://github.com/danlewis85/pycno

It's based in part on Chris Brunsdon's R package: https://cran.r-project.org/web/packages/pycno/index.html

knaaptime commented 3 years ago

awesome, thanks for sharing this! It's a huge help! Any chance you'd be open to contributing that code here? We'll add you as an author and maybe write a wrapper or two for API consistency with the other interpolators?

knaaptime commented 3 years ago

hey @danlewis85 I had a chance to play around with pycno and it's great! I wanted to check in again and see if you would be ok contributing some of that code here? We'd love to include it

I wrote a little wrapper for consistency with tobler and tweaked one or two of your functions very slightly, though i'd need your permission before integrating it here since pycno is GPL but the pysal ecosystem is BSD. Would you be alright with that?

danlewis85 commented 3 years ago

Hi @knaaptime,

Yes, fully happy for you to use the pycno code for tobler, you have my permission. The GPL license is entirely arbitrary and I have no problem with code moving to the pysal ecosystem.

knaaptime commented 3 years ago

you rule. thanks!