pysat / pysat

Generalized data analysis workflow via a consistent easy to use interface.

https://join.slack.com/t/pysat/shared_invite/zt-tb9p2fhs-MgFVmA6TwmBhfqpuZeD4rA

BSD 3-Clause "New" or "Revised" License

154 stars 38 forks source link

MAINT: remove `pysat_testing_xarray` and `pysat_testing2d_xarray` #1145

Closed jklenzing closed 1 year ago

jklenzing commented 1 year ago

Description

Addresses #908 and #1093

Removes deprecated xarray test instruments.Both are replaced by pysat_ndtesting.

Adds new kwargs to pysat_ndtesting to fully replicate the behaviour of both removed instruments.

Type of change

Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

via pytest

Test Configuration:

Operating system: Monterrey
Version number: Python 3.10.9

Checklist:

[x] Make sure you are merging into the develop (not main) branch
[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules
[x] Add a note to CHANGELOG.md, summarizing the changes

If this is a release PR, replace the first item of the above checklist with the release checklist on the wiki: https://github.com/pysat/pysat/wiki/Checklist-for-Release