search

pysat / pysatCDAAC

pysat support for CDAAC instruments
BSD 3-Clause "New" or "Revised" License
2 stars 2 forks source link

ENH: Adds support for altitude_binning across more cosmic files #19

Closed rstoneback closed 2 years ago

rstoneback commented 3 years ago

Implemented a new form of binning with the change to xarray. The native groupby in xarray doesn't work like I need along multiple dimensions. Thus, I implemented something new. Started from a stack overflow answer and went from there as needed.

Doesn't work for scintillation files since they lack the MSL_alt variable.

rstoneback commented 3 years ago

Thanks for the review @jklenzing! I think the last pull ended up further ahead than this one. If I recall, I added more file types to that one after this was done. Related to the change in download support. Anyway, I've taken a first pass at adding the new file types. It will probably take a few more commits at least.

Also, found out that for at least some of the files, they are different in 2018 than 2009. So that's fun 🐬

Whenever I see the dolphin I internally hear the flipper sound.

jklenzing commented 3 years ago

We might want to split the 2013 reprocess out into its own product (inst_id?) again. Looking at some of the other data products at CDAAC, having the preferential download might overcomplicate things from a dev standpoint.

rstoneback commented 3 years ago

We might want to split the 2013 reprocess out into its own product (inst_id?) again.

So many datasets! but yeah.....

rstoneback commented 2 years ago

Thanks @jklenzing.