Closed rstoneback closed 2 years ago
requests
is listed in setup.cfg
and in requirements.txt
....
I thought that requirements are only auto-installed when installing from pip
I thought requirements were installed with a python setup.py blah
with the exception if a package was already there, but out of version spec, it isn't updated.
Just created a new conda environment (python 3.7) and tried the above steps, have not been able to duplicate the bug.
@rstoneback, this issue was pre-v0.0.2 release (July 7). Looking through the previous version, it seems that install_requires was set up incorrectly in setup.cfg : https://github.com/pysat/pysatCDAAC/blob/v0.0.1/setup.cfg
The whole [options] section is tabbed over, which I think gets ignored when looking for requirements. I think this can be closed, unless you've seen this issue elsewhere. Sorry, forgot to bring this up at the meeting today.
Sounds good. I’m ok with the issue being closed. Thanks for the update.
On Oct 25, 2021, at 4:40 PM, Jeff Klenzing @.***> wrote:
@rstoneback https://github.com/rstoneback, this issue was pre-v0.0.2 release (July 7). Looking through the previous version, it seems that install_requires was set up incorrectly in setup.cfg : https://github.com/pysat/pysatCDAAC/blob/v0.0.1/setup.cfg https://github.com/pysat/pysatCDAAC/blob/v0.0.1/setup.cfg The whole [options] section is tabbed over, which I think gets ignored when looking for requirements. I think this can be closed, unless you've seen this issue elsewhere. Sorry, forgot to bring this up at the meeting today.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pysat/pysatCDAAC/issues/23#issuecomment-951353880, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA3N26KLT6ODFRDF7X5WRS3UIXFFJANCNFSM46VNCV3Q. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
New conda environment. Ran
python setup.py develop
on code in https://github.com/pysat/pysatCDAAC/pull/18. Upon attempted import I get an error about a lack of requests.