pysat / pysatCDAAC

pysat support for CDAAC instruments

BSD 3-Clause "New" or "Revised" License

2 stars 2 forks source link

ENH: generalize download methods #30

Closed jklenzing closed 2 years ago

jklenzing commented 3 years ago

Description

Addresses #3 (partial)

Moves the download method to pysatCDAAC.instruments.methods.general for reuse in other instruments
Downloads tar files to a temporary directory
Uses test date for postProc files to test out backup code as part of integration tests
Generalizes input to support multiple future data products
Cleans up style and implements flake8 checks

Note: v0.0.2 was released, updated changelog accordingly.

Type of change

New feature (non-breaking change which adds functionality)
This change requires a documentation update

How Has This Been Tested?

Via pytest.

Test Configuration:

Operating system: Mac OS X 10.15.7
Version number: Python 3.8.11

Checklist:

[x] Make sure you are merging into the develop (not main) branch
[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules
[x] Add a note to CHANGELOG.md, summarizing the changes
[x] Update zenodo.json file for new code contributors

jklenzing commented 3 years ago

ROADMAP comment: this should be sufficient to add in COSMIC2 IVM data.