pysat / pysatCDAAC

pysat support for CDAAC instruments

BSD 3-Clause "New" or "Revised" License

2 stars 2 forks source link

BUG/MAINT: update standards for Github Actions #46

Closed jklenzing closed 1 year ago

jklenzing commented 1 year ago

Description

Updates several bugs in the RC testing due to new behaviour at Github Actions.

--no_binary is removed in latest pip
Use --pre for pip to include pre-release versions at test pypi
Use --extra-index-url to support wheel builds
Adds test for installed the RC from test pypi

Type of change

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

At Github Actions

Checklist:

[x] Make sure you are merging into the develop (not main) branch
[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules
[x] Add a note to CHANGELOG.md, summarizing the changes
[x] Update zenodo.json file for new code contributors

JonathonMSmith commented 1 year ago

When testing these changes I was curious about the changes to pip's --no-binary option. When I try to use it myself I get this deprecation warning: DEPRECATION: --no-binary currently disables reading from the cache of locally built wheels. In the future --no-binary will not influence the wheel cache. pip 23.1 will enforce this behaviour change. A possible replacement is to use the --no-cache-dir option. You can use the flag --use-feature=no-binary-enable-wheel-cache to test the upcoming behaviour. Discussion can be found at https://github.com/pypa/pip/issues/11453