search

pysat / pysatCDAAC

pysat support for CDAAC instruments
BSD 3-Clause "New" or "Revised" License
2 stars 2 forks source link

MAINT: pysat 3.2.0 compatibility #51

Open jklenzing opened 8 months ago

jklenzing commented 8 months ago

pysat 3.2.0 changes how parse_fixed_width_filenames works. For an empty fileset, values are returned as None rather than an empty list. This is a breaking change for the cosmic_gps instrument.

Since len cannot be run on NoneType, the check for files is updated to

stored['year'] is not None and len(stored['year']) > 0

where the first bit is the pysat 3.2.0 version, and the second bit is the pysat 3.1.0 check. When 3.2.0 is released, this can be simplified and a version limit can be added.

jklenzing commented 6 months ago

There is an additional issue with pysat 3.2.0 tests failing on github actions. The tests are killed prematurely.

Cannot test this locally, as tests are killed for any pysat version prematurely.

jklenzing commented 2 weeks ago

Fixed in pysat with https://github.com/pysat/pysat/pull/1199. Cap can be removed with release of pysat 3.2.1