pysat / pysatCDAAC

pysat support for CDAAC instruments
BSD 3-Clause "New" or "Revised" License
2 stars 2 forks source link

MAINT: pysat 3.2.0 RC compliance #52

Closed jklenzing closed 7 months ago

jklenzing commented 8 months ago

Description

Addresses # (issue)

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change. Please see CONTRIBUTING.md for more guidelines.

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Test Configuration:

Checklist:

aburrell commented 8 months ago

Wondering if the additional download requirements are causing the shut off with the pysat RC?

jklenzing commented 8 months ago

Wondering if the additional download requirements are causing the shut off with the pysat RC?

It's failing with the previous release as well

jklenzing commented 8 months ago

Reworked my local config. Passes with pysat 3.1.0.

The failing test is test_load_empty for cosmic gps, tag='gfsprf'

We could add test_load_empty to the tests that are currently skipped

aburrell commented 8 months ago

We could add test_load_empty to the tests that are currently skipped

That's a good idea, since this a test that enforces a standard we weren't strict on before.

jklenzing commented 8 months ago

We could add test_load_empty to the tests that are currently skipped

That's a good idea, since this a test that enforces a standard we weren't strict on before.

Found more issues, including with unchanged tests. I think this might be related to the imports / memory

jklenzing commented 7 months ago

Merging this in to get develop up to date. Documented issues in operational workflow in #54.