search

pysat / pysatCDF

Python reader for NASA CDF file format
BSD 3-Clause "New" or "Revised" License
10 stars 7 forks source link

Expand testing to include `to_pysat()` and Improved Standards Compliance #33

Closed rstoneback closed 2 years ago

rstoneback commented 2 years ago

I improved the overall package standards, and brought build and other processes up to current times. Passes tests with flake8.

rstoneback commented 2 years ago

Expand json for bugfix authors

rstoneback commented 2 years ago

I ran into a metadata issue trying to run the pysatModels match example but it works now.

JonathonMSmith commented 2 years ago

This works for me. My only concern with a move back to pysatCDF in its current form is that it contains the CDF code. And it's using the UNIX compatible version. This means getting this running on windows is a huge pain which is a chronic hurdle for hackathons. This is out of the scope of this pull, but finding a way to incorporate or work around the CDF installations at: https://spdf.gsfc.nasa.gov/pub/software/cdf/dist/cdf37_1/windows/ would be useful for a smoother setup for all types of users. I think this requires some discussion before I write up an issue though

rstoneback commented 2 years ago

I'm all for getting pysatCDF up to the latest CDF library and, presuming I can get the multi-dimensional support going, ensuring it runs via windows and WSL. This isn't the beginning of the end, it is the end of the beginning. In the meantime, I'll need an all clear here before I can improve anything else 😈