pysat / pysatMadrigal

Madrigal instrument support for the pysat ecosystem
BSD 3-Clause "New" or "Revised" License
1 stars 1 forks source link

Added general method unit tests #59

Closed aburrell closed 2 years ago

aburrell commented 2 years ago

Description

Partially addresses #3 by adding unit tests for many of the general methods and simple file loading.

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Running the new unit tests

Test Configuration

Checklist:

If this is a release PR, replace the first item of the above checklist with the release checklist on the pysat wiki: https://github.com/pysat/pysat/wiki/Checklist-for-Release

jklenzing commented 2 years ago

I should have caught that prep_dir was used elsewhere in the pysat pull. Should have been deprecated there instead of just moved, which is why these tests are breaking. We can either use this with the develop branch of pysat, or switch back to the old path here and add a pass-through with DeprecationWarning in pysat develop to maintain usage.

aburrell commented 2 years ago

It doesn't look like that's why it's failing, though. It looks like it's failing because the tests aren't being skipped like they should be.

aburrell commented 2 years ago

@jklenzing it's passing now!