pysat / pysatMadrigal

Madrigal instrument support for the pysat ecosystem
BSD 3-Clause "New" or "Revised" License
1 stars 1 forks source link

Updated cleaning methods #62

Closed aburrell closed 2 years ago

aburrell commented 2 years ago

Description

When looking at coveralls, I discovered that the clean routines contained logic for 'none'. Since clean is not called with this input, I decided to remove it. I also:

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

import pysat
import pysatMadrigal as py_mad

jro = pysat.Instrument(inst_module=py_mad.instruments.jro_isr, tag='drifts', clean_level='none')
jro.load(2014, 20)

pysat WARNING: unknown data variable(s) ['vipn' 'dvipn' 'vipe' 'dvipe' 'vi7' 'dvi7' 'vi8' 'dvi8'], using only: ['nwlos' 'range' 'vipn2' 'dvipn2' 'vipe1' 'dvipe1' 'vi72' 'dvi72' 'vi82'
 'dvi82' 'paiwl' 'pacwl' 'pbiwl' 'pbcwl' 'pciel' 'pccel' 'pdiel' 'pdcel'
 'jro10' 'jro11']
WARNING:pysat:unknown data variable(s) ['vipn' 'dvipn' 'vipe' 'dvipe' 'vi7' 'dvi7' 'vi8' 'dvi8'], using only: ['nwlos' 'range' 'vipn2' 'dvipn2' 'vipe1' 'dvipe1' 'vi72' 'dvi72' 'vi82'
 'dvi82' 'paiwl' 'pacwl' 'pbiwl' 'pbcwl' 'pciel' 'pccel' 'pdiel' 'pdcel'
 'jro10' 'jro11']
<ipython-input-10-027e4e553f7c>:1: UserWarning: Metadata set to defaults, as they were missing in the Instrument
  jro.load(2014, 20)
pysat WARNING: interpretation of drifts below 200 km should always be done in partnership with the contact people
WARNING:pysat:interpretation of drifts below 200 km should always be done in partnership with the contact people

Test Configuration

Checklist:

If this is a release PR, replace the first item of the above checklist with the release checklist on the pysat wiki: https://github.com/pysat/pysat/wiki/Checklist-for-Release

aburrell commented 2 years ago

@jklenzing curious if you have any ideas about the best way to test for the no cleaning warning in preprocess for JRO.