pysat / pysatMadrigal

Madrigal instrument support for the pysat ecosystem
BSD 3-Clause "New" or "Revised" License
1 stars 1 forks source link

DOC: Adds example for using DMSP supporting methods. #64

Closed rstoneback closed 2 years ago

rstoneback commented 2 years ago

Description

Addresses #41

Adds examples for multiple DMSP methods. Does not currently have an example for the update ephemeris as we don't currently have a public data source for that data.

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

No code changes. Visual inspection of output documentation.

Test Configuration

Checklist:

If this is a release PR, replace the first item of the above checklist with the release checklist on the pysat wiki: https://github.com/pysat/pysat/wiki/Checklist-for-Release

rstoneback commented 2 years ago

I added this example to pysatTutorials as well under 'why not?'. I have an additional hemisphere selection function there that I can bring over here, if desired.

rstoneback commented 2 years ago

Thanks @aburrell! I misread one of your comments at first. The upside of that is I added metadata to the DMSP methods. I also added the portion requested once I sorted things out. I'll leave future reviews on this to @JonathonMSmith per previous request.

rstoneback commented 2 years ago

I followed the example and found some things that need to be fixed. More importantly, my figure does not match the example figure. pysatMadrigal_dmsp_example

I have updated my figure to the correct one. Previous figure had a hemisphere filter on there.

rstoneback commented 2 years ago

Looks much better! Since I requested changes on this one, I am willing to see it through. I'll just need @JonathonMSmith to take over for me on the tutorials. 🐴

Sounds good. Label updated to read '2D Horizontal Ion Drift'. Could be changed to '2D Roughly Horizontal ...' 🐒

rstoneback commented 2 years ago

muchas gracias!