Fixed bugs in the coordinate conversion functions introduced by assuming the azimuth originated from the x-axis in all cases, when that is not always true.
Type of change
Please delete options that are not relevant.
Bug fix (non-breaking change which fixes an issue)
How Has This Been Tested?
Ran against SuperDARN data.
Test Configuration
Operating system: OS X Big Sur
Version number: Python 3.8
Any details about your local setup that are relevant: develop branch of pysat
Checklist:
[x] Make sure you are merging into the develop (not main) branch
[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have linted the files updated in this pull request
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules
[x] Add a note to CHANGELOG.md, summarizing the changes
Description
Fixed bugs in the coordinate conversion functions introduced by assuming the azimuth originated from the x-axis in all cases, when that is not always true.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Ran against SuperDARN data.
Test Configuration
Checklist:
develop(notmain) branchCHANGELOG.md, summarizing the changesIf this is a release PR, replace the first item of the above checklist with the release checklist on the pysat wiki: https://github.com/pysat/pysat/wiki/Checklist-for-Release