pysat / pysatMadrigal

Madrigal instrument support for the pysat ecosystem
BSD 3-Clause "New" or "Revised" License
1 stars 1 forks source link

Tag style update #68

Closed aburrell closed 2 years ago

aburrell commented 2 years ago

Description

Addresses https://github.com/orgs/pysat/projects/4/views/1 by fixing the Instrument method kwarg defaults. Also improved the docstrings.

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Python broken locally, relying on CI.

Test Configuration

Checklist:

If this is a release PR, replace the first item of the above checklist with the release checklist on the pysat wiki: https://github.com/pysat/pysat/wiki/Checklist-for-Release

rstoneback commented 2 years ago

Re-running tests

rstoneback commented 2 years ago

One of the tests was cancelled. Checking if this was intentional or perhaps the system being wonky.

rstoneback commented 2 years ago

Tests are failing on gnss_tec, urllib.error.HTTPError: HTTP Error 500: Internal Server Error Code changes look good to me otherwise. Trying a re-run.... though it seems madrigal has been having some issues recently.

rstoneback commented 2 years ago

The error is now unable to open url http://cedar.openmadrigal.org/.

aburrell commented 2 years ago

It looks like enough of the versions are passing to allow merging with the remote server failures if you are ok to approve. Your call.

rstoneback commented 2 years ago

Fine with me. I'll let this round do its thing since already running.