Closed aburrell closed 2 years ago
Re-running tests
One of the tests was cancelled. Checking if this was intentional or perhaps the system being wonky.
Tests are failing on gnss_tec, urllib.error.HTTPError: HTTP Error 500: Internal Server Error
Code changes look good to me otherwise. Trying a re-run.... though it seems madrigal has been having some issues recently.
The error is now unable to open url http://cedar.openmadrigal.org/
.
It looks like enough of the versions are passing to allow merging with the remote server failures if you are ok to approve. Your call.
Fine with me. I'll let this round do its thing since already running.
Description
Addresses https://github.com/orgs/pysat/projects/4/views/1 by fixing the Instrument method kwarg defaults. Also improved the docstrings.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Python broken locally, relying on CI.
Test Configuration
Checklist:
develop
(notmain
) branchCHANGELOG.md
, summarizing the changesIf this is a release PR, replace the first item of the above checklist with the release checklist on the pysat wiki: https://github.com/pysat/pysat/wiki/Checklist-for-Release