pysat / pysatMadrigal

Madrigal instrument support for the pysat ecosystem

BSD 3-Clause "New" or "Revised" License

1 stars 1 forks source link

DMSP unit tests #83

Closed aburrell closed 1 year ago

aburrell commented 1 year ago

Description

Addresses #65 by adding unit tests for the DMSP functions. Also improves the handling of the DMSP functions and fixes docstrings.

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality or documentation)
This change requires a documentation update

How Has This Been Tested?

Added new unit tests and ran them. python -m pytest test_methods_dmsp.py

Test Configuration

Operating system: OS X Big Sur
Version number: Python 3.9
Any details about your local setup that are relevant: empty_bug branch of pysat.

Checklist:

[x] Make sure you are merging into the develop (not main) branch
[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have linted the files updated in this pull request
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules
[x] Add a note to CHANGELOG.md, summarizing the changes

If this is a release PR, replace the first item of the above checklist with the release checklist on the pysat wiki: https://github.com/pysat/pysat/wiki/Checklist-for-Release

aburrell commented 1 year ago

Ok, pysatMadrigal.instruments.methods.dmsp coverage is now at 100%. Once this is done, I can start the Madrigal release.