pysat / pysatModels

Interface for model analysis and model-data comparisons within the pysat ecosystem
BSD 3-Clause "New" or "Revised" License
8 stars 3 forks source link

Requests used by package but not in requirements.txt #85

Closed rstoneback closed 3 years ago

rstoneback commented 3 years ago

Describe the bug Setting up a new python environment for pysatModels testing. Running pytest yields an error.

To Reproduce Steps to reproduce the behavior:

  1. pytest -vs pysatModels
    ____________ ERROR collecting pysatModels/tests/test_utils_match.py ____________
    ImportError while importing test module '/Users/russellstoneback/Code/pysatModels/pysatModels/tests/test_utils_match.py'.
    Hint: make sure your test modules/packages have valid Python names.
    Traceback:
    ../../opt/anaconda3/envs/july2021/lib/python3.9/importlib/__init__.py:127: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
    pysatModels/__init__.py:20: in <module>
    from pysatModels import models  # noqa: F401
    pysatModels/models/__init__.py:15: in <module>
    from pysatModels.models import pydineof_dineof, sami2py_sami2  # noqa: F401
    pysatModels/models/pydineof_dineof.py:48: in <module>
    import requests
    E   ModuleNotFoundError: No module named 'requests'

Expected behavior Requests should be listed in requirements.txt, or , perhaps more accurately, test_requirements.txt

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

Additional context Add any other context about the problem here.

jklenzing commented 3 years ago

Closing with merge of #87