pysat / pysatNASA

pysat support for NASA Instruments
BSD 3-Clause "New" or "Revised" License
21 stars 6 forks source link

GUVI #107

Closed landsito closed 2 years ago

landsito commented 2 years ago

Description

Addresses # (issue)

Adding support for TIMED-GUVI L1C disk data (v13) into pysatNASA.

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Simple local script indicated in comments:

import pysat from datetime import datetime guvi = pysat.Instrument(platform='timed', name='guvi') guvi.download(start=datetime(2005, 6, 20), stop=datetime(2005, 6, 21)) guvi.load(yr=2005,doy=171)

Test Configuration

Checklist:

rstoneback commented 2 years ago

Friendly note that the formatting notes point to specific examples but are intended to apply throughout the file.

landsito commented 2 years ago

I have included time variables according to pysat standards. timeDayAur is left as a secondary index in case of future need to use it. Geographic coordinates, altitude and solar zenith angle were also added as coordinates into the output dataset. The pytest routines successfully passed from my side. Finally, I checked the pep8 standard on this script.

aburrell commented 2 years ago

Also, an entry in the "supported_instruments" documentation file needs to be added.

landsito commented 2 years ago

I just added a few style considerations recommended before. Thanks.

landsito commented 2 years ago

Checked style code with flake8 and autopep8.

landsito commented 2 years ago

Added this instrument into 'supported instruments' section.

aburrell commented 2 years ago

Looks like there's some bugs in the download and remote file listing functions. Feel free to poke me if you need help debugging or need the CI tests to run again.