pysat / pysatNASA

pysat support for NASA Instruments
BSD 3-Clause "New" or "Revised" License
21 stars 7 forks source link

cdflib version requirement an issue with PyHC Summer School HelioCloud setup #111

Closed rstoneback closed 2 years ago

rstoneback commented 2 years ago

Is your feature request related to a problem? Please describe. Current version requirement is cdflib<0.3.20 which directly contradicts another PyHC package requirement, which, by memory, is cdflib>0.3.20.

Describe the solution you'd like A more relaxed cdflib requirement.

Describe alternatives you've considered Leaving pysatNASA out of demos, which would be a real bummer.

Additional context Per brief discussion in developer meeting relaxing requirement may not be an issue.

jklenzing commented 2 years ago

The limit has been in place for a year, with multiple new versions of cdflib released. Going to test against new version.

jklenzing commented 2 years ago

Can't find the rationale for the cap, but I remember that 0.3.20 did not work. Using the latest creates errors in the omni hro instrument: https://github.com/pysat/pysatNASA/runs/6199105356?check_suite_focus=true

jklenzing commented 2 years ago

Update: it looks like 0.4.4 fixes the metadata issues documented in #95. Need to remove the bugfix here since the new cdflib loads meta as values, not arrays.

jklenzing commented 2 years ago

Note that versions below 0.4.4 do not fix this issue. For consistency, we would need to have this as a minimum or maximum version.

rstoneback commented 2 years ago

Based upon your report 0.4.4 should be a minimum. It is also compatible with the other package using cdflib with a req of >= 0.4.3

jklenzing commented 2 years ago

0.4.3 doesn't work here. We'd either have to set 0.4.4 as the minimum, or use a try-except for backwards compatibility

jklenzing commented 2 years ago

Closing with merge of #112