pysat / pysatNASA

pysat support for NASA Instruments
BSD 3-Clause "New" or "Revised" License
21 stars 6 forks source link

Release Candidate v0.0.3 #117

Closed jklenzing closed 2 years ago

jklenzing commented 2 years ago

Description

Alpha release fully compatible with pysat 3.0.0+.

Type of change

How Has This Been Tested?

This has been tested by running examples and unit tests locally

Test Configuration

Checklist:

JonathonMSmith commented 2 years ago

This is working really well on my windows machine!

rstoneback commented 2 years ago

Thanks @jklenzing for getting this RC up!!

I also checked this against load_meta_proc via unit tests. Everything passes but GOLD, and that fix is already somewhere.

Loading ICON data does produce a variety of UserWarnings related to meta. These are fixed in #100 but then the tests would fail until next pysat released (v3.0.2). Current thinking is I'll add a warnings.simplefilter to the summer school tutorials with ICON though of course happy to support merging of #100 into here if desired. Being on testpypi is enough for the summer school.

rstoneback commented 2 years ago

After more thought the warnings do provide an opportunity to demonstrate some of the internal checks pysat has. No need for stress on this one.

jklenzing commented 2 years ago

Thanks @jklenzing for getting this RC up!!

I also checked this against load_meta_proc via unit tests. Everything passes but GOLD, and that fix is already somewhere.

Loading ICON data does produce a variety of UserWarnings related to meta. These are fixed in #100 but then the tests would fail until next pysat released (v3.0.2). Current thinking is I'll add a warnings.simplefilter to the summer school tutorials with ICON though of course happy to support merging of #100 into here if desired. Being on testpypi is enough for the summer school.

I suspect I'll wind up pushing another patch once pysat 3.0.2 is officially released. That's holding back multiple pulls at this point. But we might as well get the bug fixes out now.