pysat / pysatNASA

pysat support for NASA Instruments
BSD 3-Clause "New" or "Revised" License
21 stars 7 forks source link

STY: streamline cdf tests, NEP 29 update July 2022 #126

Closed jklenzing closed 2 years ago

jklenzing commented 2 years ago

Description

Type of change

How Has This Been Tested?

Tested via pytest.

Test Configuration

Checklist:

rstoneback commented 2 years ago

what about version limits in setup.cfg?

jklenzing commented 2 years ago

what about version limits in setup.cfg?

I thought these were not supposed to go in setup.cfg. @aburrell?

rstoneback commented 2 years ago

I've been seeing xarray 2020.06.0 on systems, like the testing here, that I was expecting would have a previous xarray version given the dependence on pysat.

I just checked pysat. There are no version restrictions within the setup so default pysat installations are installing the newest xarray which is incompatible 😿

aburrell commented 2 years ago

I thought these were not supposed to go in setup.cfg

That is correct, it's an antipattern.

jklenzing commented 2 years ago

So if we install from pip, how does it know which versions will work?

jklenzing commented 2 years ago

Documentation tests fixed in #122. Note that the xarray cap is only in the NEP29 tests, since it does not support numpy 1.20.