search

pysat / pysatNASA

pysat support for NASA Instruments
BSD 3-Clause "New" or "Revised" License
21 stars 7 forks source link

BUG: xarray 2022.11 causes runtime error and segmentation fault #133

Closed jklenzing closed 1 year ago

jklenzing commented 1 year ago

Describe the bug In the CI tests, some instruments will fail under the latest xarray.

RuntimeError: NetCDF: HDF error
This occurs for: Test Module Tag Inst_id
python 3.9 / ubuntu icon fuv day
... icon mighti green_los_winds b
python 3.10 ubuntu icon mighti green_los_winds b
python 3.10 macos icon mighti green_los_winds b

Additionally, Segmentation Faults occur in the python 3.9 macos (icon fuv night) and python 3.8 ubuntu branches (instrument 37).

To Reproduce Inspect logs at https://github.com/pysat/pysatNASA/actions/runs/3397282902

Expected behavior Data loads fine in other xarray versions. There could be something wrong with these particular files (it's really weird since the mighti wind data works fine for a and not b. It's also suspicious that different instruments fail in different workflows.

Additional context discovered in #130

jklenzing commented 1 year ago

Whatever caused the issue, it is fixed in 2023.01 and 2023.02. Looks like there were some performance in how the code handles indices. Recommend dropping the cap.

https://docs.xarray.dev/en/stable/whats-new.html